Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MCF Wrapper Code #144

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update MCF Wrapper Code #144

wants to merge 6 commits into from

Conversation

ntalluri
Copy link
Collaborator

No description provided.

@ntalluri
Copy link
Collaborator Author

Waiting MCF code in mincostflow repo to be merged gitter-lab/min-cost-flow#8

agitter
agitter requested changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to update the Dockerfile as well. We will pull the next versioned released instead of a git commit. I will then build and push a new v2 image to DockerHub, like I did for PathLinker in #164, and we will update SPRAS to use that versioned image instead of latest. We'll add a description of the v1 and2 images to the readme (as in #164).

@agitter
Copy link
Collaborator

agitter commented Jun 24, 2024

I built and pushed the v1 Docker image in preparation for v2: https://hub.docker.com/repository/docker/reedcompbio/mincostflow/tags

@agitter
Copy link
Collaborator

agitter commented Feb 28, 2025

I resolved merge conflicts in e46ce1f. Does it look correct @ntalluri?

We may want to update the parse_output comment

Although the algorithm constructs a directed network, the resulting network is treated as undirected.

to clarify how directed edges will be passed through.

I still need to review the actual MinCostFlow changes.

@ntalluri
Copy link
Collaborator Author

ntalluri commented Mar 3, 2025

I resolved merge conflicts in e46ce1f. Does it look correct @ntalluri?

We may want to update the parse_output comment

Although the algorithm constructs a directed network, the resulting network is treated as undirected.

to clarify how directed edges will be passed through.

I still need to review the actual MinCostFlow changes.

just updated the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agitter agitter agitter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntalluri @agitter